Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SubMonintor in FileBufferOperationAction #2575

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use SubMonintor in FileBufferOperationAction #2575

wants to merge 2 commits into from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 3, 2024

done() call not necessary here and convert can also show the label and set the number of work unit.

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From d692bc40b8c85f2304cec95fc7eb76a67b18b9f6 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 3 Dec 2024 13:57:03 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 96c4987c88..9a63a5630f 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.19.0.qualifier
+Bundle-Version: 3.19.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 30b1302. ± Comparison against base commit 90ae151.

♻️ This comment has been updated with latest results.

vogella and others added 2 commits December 4, 2024 07:39
@vogella
Use SubMonintor in FileBufferOperationAction
0b0d589 
done() call not necessary here and convert can also show the label and
set the number of work unit.

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
@eclipse-platform-bot @vogella
Version bump(s) for 4.35 stream
30b1302
@vogella vogella force-pushed the submonitor-filebutteroperationaction branch from 83bac3b to 30b1302 Compare December 4, 2024 06:39
@jukzi
Copy link
Contributor

jukzi commented Dec 4, 2024

May i ask to add or modify an existing test to actually test the progress using FussyProgressMonitor? I have seen so much things broken by needless conversion to Subprogressmonitor without proper testing.

@vogella
Copy link
Contributor Author

vogella commented Dec 4, 2024

May i ask to add or modify an existing test to actually test the progress using FussyProgressMonitor? I have seen so much things broken by needless conversion to Subprogressmonitor without proper testing.

Its about removing the unnecessary done call, not about progress reporting.

@jukzi
Copy link
Contributor

jukzi commented Dec 4, 2024

The FussyProgressMonitor will check if its ok to remove the done call or not, i.e. if all progress is reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vogella @eclipse-platform-bot @jukzi